Victor Lin

Results 117 comments of Victor Lin

@tsibley > 1. Much of the templated SQL seems to interpolate values directly without proper quoting. If interpolation is used, quoting is essential, but using placeholders would be ideal. Could...

Force-pushing date parsing improvements (pre-rebase d3e466da...903d92ea)

Force-pushing date parsing improvements and force-include reporting (pre-rebase 903d92e...911e1379)

@tsibley After some more experimenting and optimization of current code, I've decided to not to pursue native SQLite for date logic: 1. [Caching](https://github.com/nextstrain/augur/commit/812293d9fe2510f27b31e460748e025825483a70) the Python user-defined functions brings the total...

Force-pushing updated tests, SQL identifier sanitizing, connection handling improvements (pre-rebase 911e1379...3eb8c987)

I investigated some data loading options today: 1. `executemany` with a generator (I was doing this wrong until 6e14640c 😬) 2. `isolation_level=None` with explicit `begin`/`commit` 3. `PRAGMA journal_mode = WAL`...

Force-pushing additional tests, styling fixes, improved type hints and docstrings (pre-rebase 3eb8c987...a73aec30)

Force-pushing rebase onto master (equivalent merge commit 42370471c87fc4fecb1d16a0a086e8208344bdf2)

@tsibley I see it as mostly (1). Should be easy to do (2) with GitHub Actions since [`dist/` is already uploaded as a release workflow artifact](https://github.com/nextstrain/augur/blob/59163622657e2c5d609377ff000aac56e6ecf809/.github/workflows/release.yaml#L27-L30). But I agree, not...

@corneliusroemer right, just having the latest release shown in the sidebar would be the main benefit. With a bit of scripting in [release.yaml](https://github.com/nextstrain/augur/blob/master/.github/workflows/release.yaml) which I'll look into, we can easily...