Victor Shepardson

is KLD calculation correct?

5

https://github.com/DmitryUlyanov/AGE/blob/0915760d0506cbb3a371aece103745e1ed4806ee/src/losses.py#L38-L41 KLD appears to use variance in place of standard deviation. utils.var() computes variance as squared distance from mean. Then it's squared again in the KLN01Loss module. Should it be...

macOS shared library fails during `init_julia`

3

Hi, I'm trying to use PackageCompiler to build a shared library which I can link into a relocatable plugin for a complex piece of C++ software, specifically, scsynth (https://supercollider.github.io/). OS:...

I think there is a bug when computing the receptive field for multichannel models: https://github.com/acids-ircam/RAVE/blob/8b250310fecfe61a6d9d53e8e5551851f4638d35/rave/core.py#L200 should the grad tensor be indexed to channel zero like `grad = x.grad[0,0].reshape(-1)` ?

`valid_signal_crop` in `validation_step`?

2

I noticed when training causal models with RAVE v2 that the validation audio sounds pretty bad. If I'm understanding correctly, it's because V2 crops to the valid (as in convolution)...

Suggestion: change the default value of `n_signal` in `train.py` to 122880. If I'm not mistaken, the current defaults for `preprocess.py` (`train.py`) set `num_signal` (`n_signal`) to the same value, 131072, which...

PR for suggestion https://github.com/acids-ircam/RAVE/issues/185

Unconditional weights / training tips?

2

Has anyone had success training the unconditional generation model? Any checkpoints or idea of how many epochs it takes to converge?

correct shellQuote on windows

7

## Motivation Not exactly a bug since the helpfile is clear, but `String.shellQuote` is not useful on windows, since single quotes don't work to escape space in cmd.exe. Would it...

expose redirect policy in `Download`

2

## Motivation `Download` doesn't follow redirects, so urls which work in a browser or with `curl -L` download as 0 bytes. In particular this affects downloads from github release pages....

incorrect padding when stride > 2?

1

In `get_padding`, I think the padding should be reduced by `stride-1` -- otherwise the last few elements of the input are discarded (they only affect the next frame, via the...