Victor Dumitrescu
Victor Dumitrescu
Thanks for the details! Just to clarify, I wasn't trying to use HMAC-DRBG with Blake2, it was just a small discrepancy that I found while testing and documenting the OCaml...
I see there is an `is_supported_alg` in Spec.HMAC_DRBG but as far as I can tell it's not exposed in EverCrypt.DRBG or anywhere else.
Hi, thanks for opening the issue and sorry for the late reply. The solution you suggested seems reasonable. Just to be sure, I'd like to test it on all our...
Hi @Frosne, could you please include the C code in the PR as well? It would be easier for me to review and benchmark. Thanks!
I benchmarked the code now in `main` against the latest OCaml release (0.5.0) and the P-256 functions in `main` seem to be 5-10% slower.
Perhaps a build issue then? Was the code that you benchmarked built in a different way than `dist/gcc-compatible`?
In the meantime, there is a new build process and new packages over in https://github.com/cryspen/hacl-packages/ so I'm wondering how important the portability of the configure script here still is.
Closing, as there seems to be another solution for this https://github.com/hacl-star/hacl-nix
I don't think this is relevant any more. opam CI also [stopped testing for it](https://github.com/ocaml/opam-repository/pull/22596#discussion_r1037429671) in the meantime, so we can also remove the `x-ci-accept-failures: ["centos-7" "oraclelinux-7"]` from the opam...
If I remember correctly (although it's been a while) the main difficulty with building with `dune` was that while it might ultimately be coerced to work with the Ctypes test...