Victor

Results 9 comments of Victor

implemented in: https://github.com/SonarSource/peachee-languages/pull/290 fixed aws permissions via: https://github.com/SonarSource/sonarsource-iam/pull/588 https://github.com/SonarSource/sonarsource-iam/pull/591

Further permissions were needed: https://github.com/SonarSource/sonarsource-iam/pull/612 https://github.com/SonarSource/sonarsource-iam/pull/613 Issue closed

link to stylelint removal: https://github.com/stylelint/stylelint/pull/5296

this comes from https://github.com/typescript-eslint/typescript-eslint/blob/dc58ff5da99989510fdbbe5575a31acd320b1808/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts#L257 seems the typechecker reports type Object for both ```ts Object.values(value) ``` and ```ts Object.values(value) as number[]; ``` testing on [this branch](/SonarSource/SonarJS/tree/fix-S4325)

Hello @StingyJack, We undestand the reasoning that you gave in both community and in here. However we will just change the message to be coherent with the [rule description](https://rules.sonarsource.com/javascript/RSPEC-1125). The...

Hello @StingyJack , it says `also reports on redundant boolean operations`, which does not mean all are redundant. That's why we went for a more cautious message. You mention that...

I refer to the rule itself: `Boolean literals should be avoided in comparison expressions == and != to improve code readability.` `=== false` cannot be simplified with `!`, so it...

After some research, seems the typechecker reports undefined when values are initialized to this.attr. Example to reproduce: ```js function test() { var foo = this.bar; foo = this.bar = 1;...

I would probably leave this ticket aside of the hardening until we do the changes we discussed in the technical direction circle, as this topic was mentioned.