Víctor Martínez Bevià comments

Results 7 comments of


                                            Víctor Martínez Bevià

Remove unneeded message on command completion. Set error output to Stderr

What about that last commit? It's the same approach they used in Kapp about this issue: https://github.com/vmware-tanzu/carvel-kapp/pull/592

Remove unneeded message on command completion. Set error output to Stderr

Hi @cppforlife could you help me with the `IsCobraInternalCommand not declared by package` error? I see no difference with the `carvel-kapp` version

Remove unneeded message on command completion. Set error output to Stderr

> > What do you think of IsCobraManagedCommand? > > 💯 Makes sense to me. > > > could you help me with the IsCobraInternalCommand not declared by package error?...

Remove unneeded message on command completion. Set error output to Stderr

Anything else needed for this PR?

Implement leader election using client-go tools

I suppose changes in the CI would have to be made to run kapp-controller with more than one replica. I don't really get the workflow of running e2e locally with...

Implement leader election using client-go tools

I'm afraid I won't have much time in the following weeks to work on this, so I'm closing the PR so others can work on this issue. Thanks for the...

kapp-controller leader election should provide safety during update operations

Hi @joe-kimmel-vmw, you mean using something like the [leaderelection](https://github.com/kubernetes/client-go/tree/master/tools/leaderelection) library from client-go, right? If that's the case, I'd be willing to work on this.