Michael Kriese

Results 952 comments of Michael Kriese

> Next step is to prove directly that Composer sorts the list of versions differently to how we do. @back-2-95 ☝️ Somebody needs to confirm composer sorting, so we can...

So it seems php compares versions on a strange thing ![image](https://user-images.githubusercontent.com/1798109/129593214-27d99501-79c9-44b0-8df2-a300e8572c92.png) it will split `1.0.0-beta.9` to `[1,0,0,'beta',9]`, so it compares numbers numerically. This can be done in javascript with `localCompare`...

https://github.com/renovatebot/renovate/blob/91a7e6b660a0ac0b66cf54a24bde3855d0633235/lib/versioning/node/index.spec.ts#L52-L53 should use `jest.spy`

All other code looks good to me

ok, thanks. we should compare the required package sizes too, so we don't switch to a more popular bigger library. so i prefer to only switch to a smaller library,...

i personally prefer luxon because I'm a fan of object oriented programming.

@HonkingGoose There is nothing to migrate for us. so the primary goal of this issue is resolved. @rarkins Should we close this issue and open a new for the other...

> It did work for me when I set it on the global level in the `.gitlab-ci.yml`: > > ``` > # workaround for https://github.com/renovatebot/renovate/issues/16561#issuecomment-1206897658 > variables: > GIT__REFS_GITLAB_INTRA_NET_USERNAME: oauth2...

@rndmh3ro That's not a reproduction, checkout the first comment for a descriptions what we need

ok, debugging against : https://gitlab.com/viceice-test/with-submodule ![image](https://user-images.githubusercontent.com/1798109/186394261-e60b59fa-852a-42ba-b03a-f92b9a191a2a.png) ![image](https://user-images.githubusercontent.com/1798109/186394287-a17a62df-a096-4e49-b841-7b848a277869.png) ![image](https://user-images.githubusercontent.com/1798109/186394469-db8e337c-a285-44e4-8d09-3d100695fd09.png) the host rule doesn't match, very strange