Michael Kriese

Results 952 comments of Michael Kriese

@nmengin Anything else i can provide?

I don't have time to work on this

I also think think you shouldn't convert to tf and parse again. you should directly transform to the parsed hcl structure. isn't the hcl lib from terraform supporting those json...

you can check if there's an additional library to `@cdktf/hcl2json` which support it

ok, in this case you should directly convert the Json to the parsed hcl format and don't generate the hcl source code.

> > ok, in this case you should directly convert the Jain to the parsed hcl format and don't generate the hcl source code. > > From the .tf.json spec...

it seems #255 can solve the issue - https://github.com/wd-David/esbuild-plugin-pino/blob/9ed42138c3a1f52440f2a496bfa41969ddd37c72/src/index.ts#L118 by time being the `createRequire` shim works for me

feel free to open a PR 🤗

> @viceice from my point of view it does not make sense to split this into a separate PR. The whole point is, that the property extraCloneOpts is only used...

I think we need to add something here: https://github.com/renovatebot/helm-charts/blob/main/charts%2Frenovate%2Ftemplates%2Fcronjob.yaml#L103