Recle E. Vibal

Results 8 comments of Recle E. Vibal

I tried doing this too, ### `yarn` vs `npm` Here are my changes: https://github.com/Appsilon/rhino/compare/main...feat/change-yarn-to-npm The shift from `yarn` to `npm` seemed to be straightforward. The syntax was different as `npm`...

I can confirm that `rhino::build_js(watch = TRUE)` keeps rebuilding JS even without any changes to `../../app/js/index.js` in a new `rhino` project. ``` > rhino::build_js(watch = TRUE) yarn run v1.22.19 $...

Is the goal here to ensure that all JS files should be in `app/js`, such that `import { jsFunction } from '../../../jsScript'` will not work and fail with `rhino::build_js()`, or...

@kamilzyla so far I have only figured out to make it work with `rhino::build_js()`. We can configure [`webpack` to resolve an alias with `path.resolve`](https://webpack.js.org/configuration/resolve/#resolvealias). I have tested, and it works...

@kamilzyla I agree about keeping it DRY as much as possible. `eslint-import-resolver-node` is not in [`package.json`](https://github.com/Appsilon/rhino/blob/main/inst/templates/node/package.json), but I saw it in [`yarn.lock`](https://github.com/Appsilon/rhino/blob/main/inst/templates/node/yarn.lock), so maybe it is a minor dependency, but...

Current changes to `rhino` for this issue: * [`webpack.config.babel.js` with alias](https://github.com/Appsilon/rhino/blob/feat/allow-root-relative-js-imports/inst/templates/node/webpack.config.babel.js) * [`.eslintrc.json` using `webpack` alias](https://github.com/Appsilon/rhino/blob/feat/allow-root-relative-js-imports/inst/templates/node/dot.eslintrc.json)

### `eslint-import-resolver-alias` I added this dependency in `package.json` and updated everything with `yarn`. It works, but I get the same error with `eslint-import-resolver-webpack`, so I think we should just stick...

I can confirm that `rhino::build_sass(watch = TRUE)` is encountering an error in Windows (full paths edited to relative paths). ``` > rhino::build_sass(watch = TRUE) yarn run v1.22.19 $ sass --no-source-map...