Victor Hargrave

Results 11 comments of Victor Hargrave

@Axelcureno how could I test this feature to ensure it's looking right?

@honstar ah I see this Readme, thanks ! - https://github.com/adobecom/milo/blob/stage/libs/features/mas/web-components/README.md

> I'm not particularly fond of the idea of consumers hooking into the milo rendering pipeline. This event previously has been removed https://github.com/adobecom/milo/pull/1282/files#diff-28218f239d8d9c4d41e1924854440b50964619e56058fdd0ae243ff5ff6c616dL126 I can imagine with a tight coupling,...

For fresh eyes looking at the PR, I've talked with with Okah & Rares and agreed to remove the events and instead add a callback to the google login function...

> I've removed the Ready for Stage label, as I didn't see any QA performed for this. We usually get either @SilviuLCF or @NadiiaSokolova involved to test and apply the...

> Is all of the new code in utils _critical_ for LCP? E.g. can we not create any links without it? Otherwise, if we can move some parts out of...

> Only gave this a high level look. This is definitely a mouthful and maintainability might not be so straightforward, but having looked into the Lingo universe, I also know...

> Hi @vhargrave , can you please confirm on below observation when verified on the below url https://main--cc--adobecom.aem.page/ch_de/creativecloud/photography?milolibs=vhargrave-lingo-link-transformation-test&martech=off the geo routing link is seen pointing to ch_de/creativecloud/photography > > in...

> Hi @vhargrave , we can see the 'query-index' XSL files are previewed and published. so once the code goes to stage & prod will the feature enables? so we...

> @vhargrave I had mentioned this in Slack but adding it here as well. CaaS is using a metadata flag `langFirst` for Lingo. They had set it up back in...