Vassil Vassilev

Results 292 comments of Vassil Vassilev

I am not sure what is the use-case here but generally building something that has an execution engine and llvm in it as a shared library is a bad idea....

That's what c++ does. I never understood why this warning is not a error. Cling can promote this warning into an error though...

> Except it doesn't work yet, as now also shown by a clean build in the CI; there are some issues left to be fixed Annoying... llvm does not allow...

Maybe we can do a death test in the test folder of core/metacling.

We probably should backport this commit. @hahnjo what do you think?

Do you have the pcm files in $ROOTSYS/lib? What does it expand to? `/opt/o2/lib/`?

I do not have time to look at this now. Maybe in a week?

Can we use the -exclude-libs option in the link command for libCling?

You probably want to collect all transitive dependencies like the way we do here: https://github.com/root-project/root/blob/2a6bdc7029881ff2d2a90e65ebbcb3017e50a613/interpreter/CMakeLists.txt#L535-L566 Everything that starts with `libLLVM` or `libclang` can be filtered out in the `--exclude-libs` flags..

@hahnjo, looks like the test failures in #13139 that were fixed by this commit are gone. Any idea why? @smuzaffar, can we test this PR for cmssw?