Veyndan Stuart

Such a change would contradict #22 as @rubenweerts made such changes to allow subclassing of `AdapterDelegatesManager`. I'm wary of the change made in that PR as is evident by the...

If you set the implementation detail methods to final, wouldn't it just be preferable to set the whole class to final and favour composition over inheritance?

`spark_fillColor` is available in the library's SNAPSHOT (i.e. the current code) but is not available in version 1.2.0. The sample app actually uses the current repository code, not version 1.2.0...

Yep, I think the main benefit that I see is that we're not limited to using `sql-psi/master`, so we can develop some new feature across sql-psi and SQLDelight without having...

I'm guessing we should also include the PRs that are in https://github.com/cashapp/sqldelight/milestone/5?

Hi @claraf3, In https://issuetracker.google.com/issues/233703110#comment1 I'd already linked a failing test which showcases the problem. The link is to this [file](https://github.com/veyndan/androidx-paging-2-to-3-regressions/blob/master/src/test/kotlin/com/veyndan/Reports.kt), mainly because the only substantive changes in the repo is...

Hey @claraf3, is there anything else that I can do to move this along?

This should be resolved by https://github.com/cashapp/sqldelight/pull/3396 which is in [2.0.0-alpha04](https://github.com/cashapp/sqldelight/releases/tag/2.0.0-alpha04).

> @veyndan Is it possible to release this fix with **_1.5.*_** ? Facing this issue when using `paging3.QueryPagingSource`. @AlecStrong Thoughts? I suppose it depends on how soon 2.0.0 will be...

This should be resolved by https://github.com/cashapp/sqldelight/pull/3396 which is in [2.0.0-alpha04](https://github.com/cashapp/sqldelight/releases/tag/2.0.0-alpha04).