Russell Jenkins

This feels like evil layered on evil (my fault for introducing with_return under the hood many moons ago!). The bug also potentially impacts any templating engine, not just Template::Toolkit. A...

@BTrey Are you setting the `SCRIPT_NAME` header somewhere in your apache config ?

@xsawyerx Plugins without a Dancer2::Plugin prefix was one the first changes applied after the release of the reworked plugin architecture (see #1175). We should allow any *engine* to live in...

Thanks for the PR @bor. I concur it would have been better if `request->base` and `request->uri_base` were consistent and returned URI objects, which would then match the behaviour of what...

Yeah, two similarly named methods sucketh (who suggested that?!). The `uri_base` method was copied from Dancer1 and currently behaves the same there. If we were deprecate it we need to...

Every module you `use Dancer2;` within creates an app (well, instantiates a Dancer2::Core::App object, Dancer2::Core::Runner keeps track of them). Each app get a name, which defaults to the namespace of...

I still think this is a better way to handle the psgi `env` munging needed (compared with including it as part of our Request class). It's taken some time, but...

The fix @xsawyerx applied for #567 was released in Dancer2-0.140000. I had a quick poke around in the param processing inside Core::Request. It looks like Dancer2 is being supplied untainted...

Apologies for the documentation for the `charset` option doesn't match the implementation. (My suspicion is that the docs were copied form D1 but never updated). "Best practice" is to use...

At a quick look; I'd suggest: `_retrieve` should return - the hashref of data if successful, - die on error if something went wrong (eg deserialisation of data fails), or...