Pavel Vergeev
Pavel Vergeev
It doesn't look like the config parser accounts for the case ``` directories_to_skip=build, dist, test_fixtures, .pytest_cache ``` because it doesn't strip whitespace: ``` 'directories_to_skip': lambda x: x.split(',') ``` (see https://github.com/devmanorg/fiasko_bro/blob/master/fiasko_bro/configparser_helpers.py#L30)...
The names can be found [here](https://github.com/devmanorg/fiasko_bro/blob/master/fiasko_bro/config.py#L4) Some of the confusing names: - `max_complexity` (it's really `max_mccabe_complexity`) - `minimum_name_length` (it's really `min_variable_name_length`) - `max_num_of_py_files` (`max_num_of_py_files_in_project`)
We should load the parameters in `setup.cfg` even inside `validate` method. The resulting precedence should be the following: default values < setup.cfg values < passed parameters
It should look similar to ``` long_description = file: README.rst, CHANGELOG.rst, LICENSE.rst ``` from [the docs](https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files). Can't be done until #95 is closed.
I propose making validator error messages serve one purpose: indicating _where_ the problem is. In other words, they should contain file and variable names, line numbers, error counts, but _should...
Lines like [this](https://github.com/devmanorg/fiasko_bro/blob/master/fiasko_bro/validators.py#L215) repeat over and over again. Since we need a way to protect ourselves from regressions, [this ticket](https://github.com/devmanorg/fiasko_bro/issues/6) should be completed first.
Since all the fixtures are located in the same repository, it does not allow to test all branches of a validator that works on a repository level. The solution is...
We import from `fiasko_bro`, but the CLI interface uses the name `fiasko`. I propose to stick to one of those so that there would be less confusion.
We should make them public, but prohibit modification. Custom validator parameters and whitelists/blacklists should be passed as `validate` function arguments. The same goes for validator groups. Then we can abolish...
Only a few validators require the project folder to be a git repository. So the requirement should be dropped and made optional.