Pavel Vergeev

Results 24 issues of Pavel Vergeev

The deploy fails on the step `Run scripts & scale dynos` with the following traceback: ``` Traceback (most recent call last): File "manage.py", line 10, in execute_from_command_line(sys.argv) File "/app/.heroku/python/lib/python2.7/site-packages/django/core/management/__init__.py", line...

When removing a bucket, the argument for removing its contents is `purge_objects`, not `purge_data`. Seems like a typo.

Suppose we have two tests which we run with pytest: ``` def test_1(): switch11 = Switch.get('switch_name1') switch12 = Switch.get('switch_name2') @override_switch('switch_name1', True) def test_2(): switch21 = Switch.get('switch_name1') switch22 = Switch.get('switch_name2') ```...

Since we [can't integrate flake8 right away](https://github.com/devmanorg/fiasko_bro/issues/75), we can start by working with its plugins. Flake8 plugins [have a well-defined Python API](http://flake8.pycqa.org/en/latest/plugin-development/index.html). For example: - https://github.com/adamchainz/flake8-tidy-imports/blob/master/flake8_tidy_imports.py - https://github.com/adamchainz/flake8-comprehensions/blob/master/flake8_comprehensions.py Fiasko should...

Right now, the validator `has_more_commits_than_origin` has the following FIXME: ``` # FIXME this check works incorrectly in case of # new commit in original repo after student forked it ```...

As described here: https://stackoverflow.com/a/33685899/3694363

The validator `has_no_long_files` counts the number of lines. But it might be too late if `fiasko` encounters a really big file: it first will try to parse it and only...

Create module `utils` and put the `*_helpers.py` files there. That will leave only `defaults.py`, `code_validator.py` and `repository_info.py` files there, which will make the navigation inside the sources much easier.

The word "warning" makes it seem like the validators are executed unconditionally, when in reality they are only executed after a failure. The name `post_error_validator_group` better describes their purpose.

One or two tests just to make sure it's not completely broken would be fine for now.