vemv

Results 426 comments of vemv

I'd try to replicate this test as part of this PR: https://github.com/clojure-emacs/orchard/blob/dbe1bef72697a89843763dd112d151a9f365e5c8/test/orchard/java/classpath_test/third_party_compat_test.clj - else I'd fear that users of this feature could have issues that could manifest themselves in third-party...

> If you get stuff back it works, otherwise you got an exception as the failure mode? The side-effects of using dynapath were causing the result of `(clojure.java.classpath/classpath-directories)` to be...

Specifically, it can be a pain when one invokes `lein repl` in end-user projects with `warn-on-reflection` and one sees a wall of warns coming from clojure-emacs tools. i.e. even if...

> Yet locally I get no conflicting deps: check out how :pedantic is set. You can use `CI=true lein deps` or maybe edit temporarily project.clj > I tried just taking...

I'll add the suggested deftest, at least we should be certain we're not breaking people not using this feature (which is exactly what happened with Orchard) Btw something might be...

Side note, the pinpointed code seems a good target for parallelization. Perhaps if done with reducers, the change wouldn't be too invasive.

One last note, `(->> (core/dirs-on-classpath) (mapcat (partial core/find-in-dir (some-fn core/clj-file? core/cljc-file?))) count)` returns 276 for me, each file having a reasonable size. i.e. it's not an humongous project.

I further debugged this. * The culrpit boils down to `refactor-nrepl.find.find-symbol/find-symbol-in-file` * Specifically, its `(ana/ns-ast file-content)` call * One specific input that will cause it to OOM is the following:...

Hey there, have you had a chance (or foresee one soon enough)? Btw, this issue report is a bit messy, it boils down to the last comment. I can close...

Hi, thanks for attending the issue! Yes I could still reproduce it. Updated repro instuctions are as follow: * `git checkout` fresh https://github.com/clojure-emacs/refactor-nrepl master * `curl https://gist.githubusercontent.com/vemv/a01b63102c3fb6b19d37f376e78546fd/raw/74d064cac449f6063f4751f6fa9f3e8e8fe53899/gistfile1.txt | git apply`...