Luca Versari

Results 123 comments of Luca Versari

Also a warning when testing a non-existent solution could be useful.

High level comment: why don't we leave figuring out of formatting to appropriate language-specific tooling? (i.e. clang-format, autopep8 or whatever)

Basically, "whatever is in the list of inputs of the DAG" is at least a reasonable first approximation (assuming those files are sufficient for rebuilding the DAG)

My 2c: generated files such as statements should _not_ be in that bundle -- so that if the generation process improves, one can re-trigger it without actually importing again the...

Can you check that #3658 fixes this?

Seems like an Ubuntu issue to me, the issue linked above says that this should fix it: ``` echo "kernel.apparmor_restrict_unprivileged_userns = 0" >/etc/sysctl.d/99-userns.conf sysctl --system ``` This is a system...

> The Windows one is that you are linking with a different MSVC runtime library. By default, it will use `MultiThreadedDLL` (CMake) or `/MD` (link.exe) variant, which should be consistent...

Right, but couldn't the build script figure out that crt-static is being use and then set the variable conditionally? On Sun, 5 May 2024, 11:45 Inflation, ***@***.***> wrote: > Excuse...

> In theory, yes. However, these customizations should left untouched so people can easily overwrite anything they need. From what I can see the env variable is set here: https://github.com/inflation/jpegxl-rs/blob/78bd163950c15e50e340f1afa8b566ecd38a2713/jpegxl-src/src/lib.rs#L42...

I managed to find the configuration of the zola pipeline, and I don't see anything that would indicate that they are using crt-static on windows: https://github.com/getzola/zola/blob/b93640851eab8db6cc0f47419e050df2c762f3c4/azure-pipelines.yml#L39, so I would guess...