Luca Versari

> Can you add some tests? They are in imageproc/tests Absolutely - what do you think I should test? For now I just added a PNG to JXL test.

> Maybe a JXL output with a JXL input? The CI failures look legit though Ah, JXL *reading* is not supported :D do you think I should add that? As...

> > Ah, JXL reading is not supported :D do you think I should add that? > > It depends whether it can be added or not. If so then...

> > it depends on a different version of "image", and trying to upgrade the dependency for zola to 0.25 produced some dependency incompatibility errors. > > I will update...

Thanks! I updated the PR accordingly (also squashing the commits, since I was going to rebase anyway...)

> Can you rebase? CI is fixed minus windows which i'll look at later I made a mess with rebasing, but it should be done now :-)

> CI failures seem legit Yep, they are, I am hoping they will be resolved on the jpegxl_rs side (https://github.com/inflation/jpegxl-rs/pull/50) and jxl side (https://github.com/inflation/jpegxl-rs/issues/51) as soon as I can get...

The pnm decoding should be fixed in the latest main. Could you try again?

> > ```shell > > > convert Bellisseria_ALL.composited.png Bellisseria_ALL.composited.ppm > > > cjxl --streaming_input --streaming_output Bellisseria_ALL.composited.ppm Bellisseria_ALL.composited.jxl > > JPEG XL encoder v0.10.0 07203da0 [AVX2,SSE4,SSE2] > > ``` > >...

I'm in principle against this change, unless there's a known good reason to deviate from the (JPEG/JXL) spec. On Thu, 3 Aug 2023, 09:19 Jon Sneyers, ***@***.***> wrote: > @jonsneyers...