af su comments

Results 10 comments of


                                            af su

Add preferred_username to local static passwords

Hi @cldfzn @ioboi , I am also concerned about this issue. Is there any progress now?

refactor(redis): improve init logic for JedisPooled client

> @vegetablest please elaborate, the description is not clear. Tests are also missing I added two new unit tests. Before the refactoring, executing `testAuthPass` failed.

refactor(redis): improve init logic for JedisPooled client

> @vegetablest can you change that for `RedisChatMemoryStore` too? In that case you can remove the ensureNotBlank for the user Sorry, I'm too far behind the main branch. I will...

refactor(redis): improve init logic for JedisPooled client

I think these two unit tests can be deleted. @zambrinf WDYT?

refactor(redis): improve init logic for JedisPooled client

> @vegetablest yes, but add one test to assure it works with user null and password not null I've added two unit tests. Could you please review them when you...

refactor(redis): improve init logic for JedisPooled client

@langchain4j @zambrinf Any other suggestions?

Allow arbitrary claims from the IDToken to be injected into the response header

@artificiosus Thanks for the suggestion! I think it’s a great idea, but it might be better to address this in a separate PR to keep the focus on the issue...

Allow arbitrary claims from the IDToken to be injected into the response header

updated

Allow arbitrary claims from the IDToken to be injected into the response header

> Would this also work for injectRequestHeaders? I want to pass the value from the token key some_information into a HEADER and pass it to upstream like so: > >...

Allow arbitrary claims from the IDToken to be injected into the response header

@sstone1 Thanks for the clarification! Yes, I’ve confirmed that it's already working as expected with `injectRequestHeaders`.