Toon Verwerft

Results 280 comments of Toon Verwerft

Thanks for reporting, I can confirm this is a bug but haven't found a solution yet. Feel free to dive into the specifics to figure out what is going wrong...

That's some fine feedback @kira0269 ! So if I understand correctly, the main issue is in the fact that the LazyTaskConfig is containing information from the 'compiled' container and not...

Owkay, I think I get what you are saying. Implementation wise, there are already quite some classes and code just to get the task configured. I think we should inspect...

@kira0269 I've created a quick draft of what change I had in mind: https://github.com/phpro/grumphp/pull/1177 This seems to be doing the trick as well. Your feedback is welcome. (it's just a...

Thanks for the PR. I'm a bit confused: There is already a draft, so wouldn't it be better to start from 1 PR and try to get that as good...

No problem. Feel free to give your feedback on the initial PR so that we can try to get that one as good as possible.

True, I think that part could be covered by making it configurable per task basis instead of on a global basis as commented here https://github.com/phpro/grumphp/pull/1136/files#r1608281196. Not sure how easy it...

> Regarding https://github.com/phpro/grumphp/pull/1136/files#r1608281196, I need to understand more what you are proposing there. You mean, for instance, that `phpcs` could run on a push while `phpstan` on commit? Indeed: the...

We notices this PR became inactive. If you wish to continue, feel free to pick it up again. If not, we will be closing this PR soon. Thanks for your...

I don't know how to enable it and keep it enabled for this PR. You might want to run the actions in your local repository instead.