Toon Verwerft
Toon Verwerft
Cool! I'm a bit busy this week but will try to play around with it soon :)
Just wanted to give you a small update @nielsdos : * The new entity substitution works flawlessly * Renaming nodes works in general, but I have a feeling there are...
@nielsdos All unit tests are succeeding, which is nice. Next up - static analysis: > 64 errors found I'm using the stubs that are included in your PR which are...
> Can you share an example of a type inference error? I'm just gonna paste the full list of errors here so that you can skim around it - but...
Stubs issues: @nielsdos I was fixing some psalm issues and was bumping against following issues: * ✅ Collections don't contain more detailed `iterable` information : manually adding to the stub...
@nielsdos If I understand the problem correctly, then it's about some kind of transition from `HTMLElement` to regular `Element` and the other way around? I'm a bit confused by the...
@nielsdos Thanks for the review on the static analysis part. I was able to get it all covered now.
> Yes, leave it out for HTMLElement for example. I think you're right this is strange though. Or leave the rename method out entirely... What also crossed my mind is...
> Please see [nielsdos/php-src#106](https://github.com/nielsdos/php-src/pull/106) This implements a new method `XMLWriter::openStream(resource $stream)`. It takes an open stream and writes its data to it. Wow that was fast 😮 > When implementing...
@nielsdos nice! Let's hope for a smooth acceptance path then :)