Tariq Hasan comments

Results 63 comments of


                                            Tariq Hasan

Introduced error constants and replaced reflect with cmp

Okay. I thought that these might have been flakiness issues as the CI workflow seems to pass and fail quite unpredictably for this test case. I am rebasing the PR.

Introduced error constants and replaced reflect with cmp

Got it.

Introduced error constants and replaced reflect with cmp

I am working through them now.

Introduced error constants and replaced reflect with cmp

I did run into the issues here before. ![image](https://github.com/kubeflow/katib/assets/131830071/17e4b4d6-96e1-44cd-b3c0-83a3e372e511) ![image](https://github.com/kubeflow/katib/assets/131830071/d21be919-b056-40db-b731-8aa83061ec2e) The errors are not always reproducible however. I usually get these errors in the first one to three runs of...

Introduced error constants and replaced reflect with cmp

Please ignore my comments above. The error was due to the order of test case execution in `cases` in `TestGetRunSpecWithHPConfigMap`. I fixed the issue in this [commit](https://github.com/kubeflow/katib/pull/2289/commits/87a6abcb996f9be974fb0708a2ca0d93824d6d19) and rebased the...

Replace reflect.DeepEqual with cmp.Diff in tests

@tenzen-y I would like to take on this ticket.

Replace reflect.DeepEqual with cmp.Diff in tests

/assign

Replace reflect.DeepEqual with cmp.Diff in tests

I am working on it. I will open a new PR.

Interpolate global variables in SQL block configuration

I am working on this now. Will let you know if there are any issues.

Migrate away from deprecated github.com/hpcloud/tail

I am interested to take on this one. /assign