katib icon indicating copy to clipboard operation
katib copied to clipboard

Migrate away from deprecated github.com/hpcloud/tail

Open AndersBennedsgaard opened this issue 10 months ago • 4 comments

/kind feature

Describe the solution you'd like

As https://github.com/hpcloud/tail hasn't been touched for 6 years (it is using Go v1.5.1), and the https://github.com/hpcloud organisation doesn't have any (public) members, we should really stop depending on their code. Multiple forks has been created, but it seems like https://github.com/nxadm/tail is the most popular one, so this could be a potential candidate

Anything else you would like to add:

The reason I found this usage of a deprecated package, is that I hit https://github.com/kubeflow/katib/issues/1769 and tried to investigate the issue


Love this feature? Give it a 👍 We prioritize the features with the most 👍

AndersBennedsgaard avatar Apr 04 '24 12:04 AndersBennedsgaard

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 03 '24 15:07 github-actions[bot]

/help /good-first-issue

andreyvelich avatar Jul 03 '24 16:07 andreyvelich

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/help /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar Jul 03 '24 16:07 google-oss-prow[bot]

I am interested to take on this one.

/assign

tariq-hasan avatar Jul 03 '24 16:07 tariq-hasan