vecto

vecto copied to clipboard

Unstable results with LRCos

2

Re-running benchmarks of LRCos produces differences of 1 or 2 correct answers out of the 50 questions in some individual BATS tests, so that the benchmark accuracy varies by up...

ekaf

Fail to reproduce the result in "Subcharacter Information in Japanese Embeddings: When Is It Worth It?"

4

Hi. I tried to use this project to reproduce the results in ``` Karpinska, Marzena, et al. "Subcharacter Information in Japanese Embeddings: When Is It Worth It?." Proceedings of the...

yuanzhiKe

https://github.com/vecto-ai/vecto/blob/7d5d7b8690e2b52cbe32bea661caa21614e9c60d/vecto/embeddings/dense.py#L244 If OOV then `i == 0` which means that `i < 0` is always `False` hence `has_word` always return True I think it would make more sense for `get_id`...

pierremarchal

bakarov