Esun Kim

Results 84 comments of Esun Kim

@tvalentyn bisecting would be helpful and callstack when it's hanging would be also helpful if possible.

@davidrabinowitz Yeah that's a good point. I added the same check routine of [gax-java](https://github.com/googleapis/gax-java/blob/209b4944feba1c62be2c9de4545e3b01a806b738/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java#L288).

@mprashanthsagar PTAL

@murgatroid99 @nicolasnoble PTAL

It looks good. Would you run `tools/buildgen/generate_projects.sh`?

[grpc_build_artifacts_multiplatform](https://fusion2.corp.google.com/invocations/885f4e77-1c14-441b-9fd3-bbe2fd444217): running

To get this merged, two things needs to be done; 1. run tools/buildgen/generate_projects.sh 2. address `test/cpp/end2end/client_fork_test.cc:18:#include ` from `tools/run_tests/sanity/cpp_banned_constructs.sh`. you may want to add a new exception there.