Valentin Churavy

Results 1413 comments of Valentin Churavy

I rather not overcomplicate the `@benchmark` interface. > Additionally, is there some way to take advantage of knowing the primary goal of a benchmark is to compare 2 functions by,...

Improving the docs would be fantastic! If you have the time maybe you can take a stab at it?

I don't think there is a canonical solution.

In BenchmarkTools GC time is always printed as a ratio. That's why we do `gcratio(maximum(trial))`. So yes the fact that we say the "maximum GC" is `0.0%` is confusing See...

This is where `@benchmark` gives you a bit more info: ``` julia> function dosomething() count[] += 1 sleep(1) end dosomething (generic function with 1 method) julia> count = Ref(0) Base.RefValue{Int64}(0)...

> (how would it do that?). For a description of the tuning process see https://github.com/JuliaCI/BenchmarkTools.jl/blob/58af70428fbcbe4862453ddf135907ddc2032862/src/execution.jl#L151 or see the code at https://github.com/JuliaCI/BenchmarkTools.jl/blob/58af70428fbcbe4862453ddf135907ddc2032862/src/execution.jl#L135 The tuning phase ignores `samples` and uses the full...

That sounds like a nice addition!

Probably depends on what Font your browser defaults to, since for me https://github.com/JuliaCI/BenchmarkTools.jl/pull/243#discussion_r688361580 is misaligned.

Still an issue the text example in #260 looks like: ![Screenshot from 2021-09-22 10-00-08](https://user-images.githubusercontent.com/145258/134358058-61d87be8-4db7-4bcc-bc5d-2138a455baf0.png) On Firefox+Linux (and also Slack I think)

Yeah we should no longer get these from Julia normally, but of course most other LLVM are not hardened and I don't know how weak symbols will play with it