Valentin Churavy

Results 1411 comments of Valentin Churavy

@tecosaur any easy improvements we could do? Maybe add a `compress` variant of show?

One of the issues is that frequency scaling introduces variance into the system. If your question is "how fast is this code running on my system", that doesn't matter as...

I think instead of Mac, what would be more interesting is the 90/95/99 percentile

Do you want to give implementing this a go?

It's wall clock. I started adding CPU time in https://github.com/JuliaCI/BenchmarkTools.jl/pull/94 but I got distracted along the way (and found it to be tricky across platforms)

Also of note that on certain platforms (Windows) timer resolution is about 100ns (at least last time I checked that is what we were using https://github.com/JuliaCI/BenchmarkTools.jl/pull/94#issuecomment-359639945)

The code in `timers` is mostly taken from `google/benchmark` and that is under Apache v2.0. The code is fairly basic, but in order to make sure I retained the copyright...

The Apache license does mandate that derived works keep the license notice intact and include a copy of the license and mention all modifications... > "Derivative Works" shall mean any...

That is contrarian to my understanding of the license. I translated code under the Apache license to Julia, therefore creating a derivative work. According to the license I must a;...

Ok, changed the license to MIT, while complying with the Apache requirement of retaining the license notices. This is pretty much ready to merge from my side.