Valentin Churavy comments

Results 1408 comments of


                                            Valentin Churavy

Alloc -> Malloc downgrade on sret

This is a tape allocation? Yes I think what I mentioned would work here

`CombinedAdjointThunk` should also return ret value

https://github.com/wsmoses/Enzyme.jl/blob/aa78016bfd046689aa33b2ceba50049b329dd0d5/src/compiler.jl#L1189

`CombinedAdjointThunk` should also return ret value

@tansongchen this might be a good place to start.

Use Anonymous Struct for sret

I plan to merge this as soon as CI agrees, it's a strict improvement and the remaining issues with sret can be fixed independently.

Enzyme + KA Stalls on Error instead of reporting it

Can you use redirect the output to a file an post that? Any you are saying that instead of terminating upon error it's just hanging and waiting?

Enzyme + KA Stalls on Error instead of reporting it

Ah no it's stalling on the CPU and erroring in the GPU.

Enzyme + KA Stalls on Error instead of reporting it

Thanks for the CPU part can you try https://docs.julialang.org/en/v1.8.0-rc1/stdlib/Profile/#Triggered-During-Execution

Enzyme + KA Stalls on Error instead of reporting it

Just as a note see the: ``` @exception9 = private unnamed_addr constant [25 x i8] c"undefined variable error\00", align 1 ``` In the output? That means you have an undefined...

Enzyme + KA Stalls on Error instead of reporting it

Well we shouldn't stall, but actually error... So something dastardly going on.

`Box{AbstractFloat}()` calling convention

Could you re-run this on a Linux machine? We get better stacktraces there. Ideally this would also be more minimized, and please provide a Manifest.toml