Enzyme.jl icon indicating copy to clipboard operation
Enzyme.jl copied to clipboard

Use Anonymous Struct for sret

Open vchuravy opened this issue 2 years ago • 2 comments

vchuravy avatar Aug 09 '22 19:08 vchuravy

Test Summary: | Pass  Total
Bessel        |   24     24
AbstractType calling convention: Test Failed at /mnt/Data/git/Enzyme.jl/test/runtests.jl:431
  Expression: Enzyme.autodiff(dxdt_pred, Active(1.0))
    Expected: UndefRefError
  No exception thrown
Stacktrace:
 [1] macro expansion
   @ /mnt/Data/git/Enzyme.jl/test/runtests.jl:431 [inlined]
 [2] macro expansion
   @ /mnt/Data/git/Enzyme.jl/julia-1.7.2/share/julia/stdlib/v1.7/Test/src/Test.jl:1283 [inlined]
 [3] top-level scope
   @ /mnt/Data/git/Enzyme.jl/test/runtests.jl:429
Test Summary:                   | Fail  Total
AbstractType calling convention |    1      1
ERROR: LoadError: Some tests did not pass: 0 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /mnt/Data/git/Enzyme.jl/test/runtests.jl:428
ERROR: Package Enzyme errored during testing

Seemignly not sufficient, throwing this back to you @vchuravy

wsmoses avatar Aug 11 '22 19:08 wsmoses

Wait actually, that is good not to have thrown, one second.

wsmoses avatar Aug 11 '22 19:08 wsmoses

I plan to merge this as soon as CI agrees, it's a strict improvement and the remaining issues with sret can be fixed independently.

vchuravy avatar Aug 19 '22 15:08 vchuravy

Check also https://github.com/EnzymeAD/Enzyme.jl/issues/293 which was a minimal example not resolved by iirc.

wsmoses avatar Aug 19 '22 16:08 wsmoses

(it also is referenced by several other errors that became variants of that issue, some of which were in fact resolved by the PR)

wsmoses avatar Aug 19 '22 16:08 wsmoses