Valentin Chaboche
Valentin Chaboche
Used @tmcgilchrist suggestion to reduce the code duplication and rebased to master. The commits should be squashed on merge, I'm not sure each of them compile and it's not that...
I noticed the behavior while providing printers for #181
What I propose is very similar to what you did for shrinkers: ```ocaml let quad = ... ~shrink:(Shrink.quad (_opt_or a.shrink Shrink.nil) (_opt_or b.shrink Shrink.nil) (_opt_or c.shrink Shrink.nil) (_opt_or d.shrink Shrink.nil))...
> Thanks for this! pray > > In QCheck(1) there's: > > ```ocaml > val set_shrink : 'a Shrink.t -> 'a arbitrary -> 'a arbitrary > ``` > > meaning...
Hi! Sorry for the huge delay. Pushed a rebased branch: 1. Used your suggestion for the documentation 2. Went fo `no_shrink`, I like the name, explicit enough and fits well...
If we plan on adding the shrinker deriver in the ppx, we should decide before any release the plugins names: #190.
Actually, I wonder if we need to remove `merlin.hide`: ```ocaml module A = struct type t = int [@@deriving qcheck] end ``` Merlin knows about `Q.gen`
Cool! Haven't look very deep in the code yet but it could be nice to both add the generators to `QCheck2` and append the changelog :).
Looks good!