Valentin Chaboche
Valentin Chaboche
> Thanks for taking a stab at this! Overall this LGTM grinning > > I spotted a few occurrences of `small_nat` in the interface and in the implementation. It would...
I think `_pos` is more convenient: we have a lot of suffixes in the module. For some it's obvious (e.g. `_neg`) but its more complicated for `_big` for instance.
Regarding `make_primitive` I think we could change to: ``` val make_primitive : ?shrink : ('a -> 'a Seq.t) -> (Random.State.t -> 'a) -> 'a t ``` where `?(shrink = fun...
While addressing the suffixes and optional parameters (except `make_primitive` yet) I also looked for occurrences with `git grep `. I might have removed the vast majority but its a error-prone...
> I noticed that > * nat is non-uniform and at most 10.000 - while int is uniform over all OCaml ints. (one should use nat_origin 0 to get a...
I really wish I can revive this PR, however, I'm still busy and I will be for a while. Once I get the time that'll be the first thing I'll...
I strongly agree with @Sir4ur0n. It also makes win a LOT of time, got pretty sad when I disabled it in this project
Instrumented runtime might be easy. Crowbar has ```ocaml type src = Random of Random.State.t | Fd of Unix.file_descr ``` Should be pretty simple to copy this behavior
I'll make experimentation about that as soon as I can :)
From what I did so far: the issue is that we lose control on generation using bytes only. For instance (almost like in Crowbar): ```ocaml let float : t float...