Victor Boctor

Results 65 comments of Victor Boctor

Kickbox suggests that this domain is disposable. See [here](https://open.kickbox.io/v1/disposable/spamgourmet.com) I have added a feature that enables consumers of the library to add / remove domains from the list of disposable...

Thanks @eduardev for your contribution. I'm not sure of the benefit of using a cache here. Is there a measurable perf improvement here? I have improved the latest implementation to...

We can model it in the data files as *.bulc.club and update the code to handle such case by using a custom method rather than in_array() that can do string...

@raspopov I would love to enrich the auth plugin framework to: - Support lookup of users from directory. - Support authentication models where user doesn't need to enter username. It...

Thanks @badfiles - the change looks good. I've added some comments to address. I suggest updating the commit name to reflect the issue being fixed (e.g. "Fix email notification for...

Thanks @cproensa for your feedback. > Notification generators, as the general application events that would create the individual notification items for each user, when an event occurs. I haven't implemented...

@cproensa If you think about it, the best terminology for a logical change is an "Event" that core and plugins can subscribe to (e.g. note added, issue assigned, issue status...

@atrol @dregad thoughts on this?

Looks like the pull request description is truncated at the end.

Good cleanup, thanks @dregad :+1:. Though it is a tricky part to change in such a big way :) -- but I like that in the future, it will be...