Victor Barua
Victor Barua
Very early sketch of a MatchRecognizeRel
A number of PRs have introduced changes to functions extensions which don't conform to the spec. The most recent example was https://github.com/substrait-io/substrait/pull/247. Manual review has proven insufficient to catch these...
The current FetchRel https://github.com/substrait-io/substrait/blob/b663a4aee64e6237566a1b930549d90b909e322e/proto/substrait/algebra.proto#L190-L199 as describe in the [spec](https://github.com/substrait-io/substrait/blob/b663a4aee64e6237566a1b930549d90b909e322e/proto/substrait/algebra.proto#L190-L199) does not allow us to represent queries like ```sql SELECT * FROM foo LIMIT ALL OFFSET 10; SELECT * FROM bar...
The current definitions of [Preceding and Following Window Bounds](https://github.com/substrait-io/substrait/blob/e564cf0b3b769491c19016d92d195b5f62361775/proto/substrait/algebra.proto#L1063-L1079) both declare the offset as ``` proto int64 offset = 1; ``` with a note > A strictly positive integer specifying...
The nullability of functions like `coalesce`, `least_skip_null` and `greatest_skip_null` can be expressed in words as: ``` The function returns null only if all arguments evaluate to null. ``` or equivalently...
The [spec](https://substrait.io/relations/logical_relations/#set-operation) documents the direct output order of a SetRel as ``` The field order of the inputs. All inputs must have identical fields. ``` Having producers align the input...
# Problem It is difficult to re-use existing functions and types from one extension in another extension as there is no mechanism to reference functions and types outside of the...
### Describe the bug In various engines, the order in which intervals are added to dates can affect the final value. This is especially noticeable with leap years. Datafusion appears...
### Describe the bug As written, the test assertion in https://github.com/apache/datafusion/blob/1fce2a98ef9c7f8dbd7f3dedcaf4aa069ab92154/datafusion/substrait/tests/cases/logical_plans.rs#L46-L50 should fail because DataFusion registers the `data` table with 5 fields [a, b, c, d, e] but the schema...
The [protobuf comment](https://github.com/substrait-io/substrait/blob/1f3354d9f0f8b4425e98623f34d1e4578e2142bd/proto/substrait/algebra.proto#L423-L425) > In addition to a field being emitted per input field an extra int64 field is emitted Disagrees with the [written spec](https://substrait.io/relations/physical_relations/#expand-operation): > The expand fields followed...