Henrique Mouta
Henrique Mouta
Is there anything else that needs to be addressed before we can merge this PR to `develop`?
Just waiting for the final approval by @Automattic/vip-platform-cantina :)
> Disabling cron means we won't be getting SDS syncs. Having that data fall out of sync isn't super ideal, but atm there's not a means to only run one...
Thank you! I just addressed your feedback, and added some more PHPDOC comments on the `_` private functions.
Yes, that makes sense, thank you! I reverted the commit with the version bump. What else is missing so that we can move this PR forward?
Hey @rodruiz, thank you for submitting the PR! This solution seems to be a good fix, however, for compatibility reasons, changing the query var would bring some issues. For example,...
Thanks for the feedback, I have applied your suggestions. I also added the missing PHPCS changes on the `class-wp-push-syndication-server.php` file, feel free to take a look!
Thanks, @GaryJones! Actually writing a unit test for this functionality is a great idea, and I just added the first draft with 3 tests and 13 assertions. Let me know...
Thanks for the feedback @GaryJones! I just went ahead and refactored the code with your suggestions. It's possible that I might have overengineered it a little bit, but I'm open...
@GaryJones thanks for all the feedback! I did another refactor, and changed the `Syndication_Encryptor` to an interface, and moved the encryptor loading logic to the plugin root file, along with...