zoninator icon indicating copy to clipboard operation
zoninator copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

PHPCS fixes.

Open vaurdan opened this issue 3 years ago • 4 comments

First extensive pass on PHPCS issues and warnings.

vaurdan avatar Jul 23 '21 15:07 vaurdan

Thank you! I just addressed your feedback, and added some more PHPDOC comments on the _ private functions.

vaurdan avatar Jul 28 '21 15:07 vaurdan

Personally, I prefer to see Version Bumps done in their own PR, which also then write changelogs, update README's, and other meta stuff.

GaryJones avatar Aug 09 '21 06:08 GaryJones

Yes, that makes sense, thank you! I reverted the commit with the version bump.

What else is missing so that we can move this PR forward?

vaurdan avatar Aug 16 '21 15:08 vaurdan

Other than squashing the 7 commits into something that makes sense as a granular unit of work (probably just one or two commits), then I think you're done.

GaryJones avatar Aug 17 '21 17:08 GaryJones