Vatroslav Vrbanic comments

Results 35 comments of


                                            Vatroslav Vrbanic

Use camelCase for exposed / public props and methods (Svelte's code convention)

I've already done a lot of this, just needs a final check + there are some props that still need to be changed.

`Scene` : check possible negative effect between `scene` / `root_scene` instances and `SvelthreeAnimation`

Ok, I've checked it. Didn't found nothing to worry about so far.

GitHub Copilot for commits

This would be really cool + option to: - make them [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) compliant - make them < 50 chars long

Examine / nail down `SvelteKit` / `Vite` classes suffixing (if duplicate class names) and chunks naming

**BUILD** `vite.config`: - `ssr: { noExternal: ['three'] }` - `optimizeDeps: { include: ['three', 'svelthree/utils', 'svelthree/stores'] }` `svelte.config`: - `ssr: true` --- `.svelte-kit/output/client/_app/immutable/chunks/OrbitControls-#.js` contains almost all of the `three`-stuff incl.: -...

Error : to make it work using sveltekit

Hello @borisrose , Hello @engageintellect! ⚠️ **Don't use the version published on npm!** (very old / the very first proof of concept) ⚠️ **`svelthree` is not stable / still experimental...