Vasily Kirichenko comments

Results 193 comments of


                                            Vasily Kirichenko

VSLanguageService -> FSharp.Editing

I don't think `LanguageService` should accumulate more functionality. In fact, I'd like make it lighter. Feature specific code should be spread among other types.

"Resolve unopened" does not fix types whose unqualified names match opened modules

@dungpa I'll try to fix this. However, I'm not sure how hard it will be since the feature implementation is a bit complicated.

"Resolve unopened" does not fix types whose unqualified names match opened modules

Sorry for that :( it should be refactored - more types, shorter functions.

"Resolve unopened" does not fix types whose unqualified names match opened modules

No.

"Resolve unopened" does not fix types whose unqualified names match opened modules

The feature has been ported to VFT repo.

[Resolve unopened namespaces] Smart tagger does not appear on active patterns

No. It's not a huge bug and it seems to be not as easy to fix, so I'm not going to fix it soon.

[Resolve unopened namespaces] Smart tagger does not appear on active patterns

The feature has been ported to VFT repo.

Renaming virtual methods doesn't work

Hm. I've never used virtual methods in F# :)

[Find all references] It considers nested functions / APs as public

I've investigated the issue and it's turned out it's impossible to determine whether an active pattern is defined on module level or inside a function/method. When user launches Find all...

[Find all references] It considers nested functions / APs as public

Yeah, I also thought so, but EnclosingEntity is null :(