Vasiliy Ulyanov
Vasiliy Ulyanov
I personally do not have a strong opinion. Specifically, in this PR, some functions return just a single value of type `[]metav1.StatusCause`. Probably there is no much benefit in using...
CDI uses StorageProfile CR to define the preferred settings (e.g. access mode) for various storage providers. Apparently there is no default profile for your storage driver, hence you need to...
I think this was the actual reason: ``` message: 'failed to configure vmi network: setup failed, err: open /proc/sys/net/ipv4/ip_unprivileged_port_start: no such file or directory' ``` It requires kernel >= 4.11.
Just a thought: what if e.g. `/var/lib/kubelet` is already a symlink. I wonder how safepath will handle it.
> Shouldn't this fail early? Not 100% sure... It just reminds me about the issue raised some time ago. KubeVirt does not work with 'non-standard' kubelet directories. The proposed workaround...
~This issue with `dac_override` looks very similar to: https://github.com/kubevirt/kubevirt/issues/8615#issuecomment-1287502337. Though there it was Alpine on Equinix bare metal server.~ UPD: ah, yeah, I missed that the issue has been mentioned...
I am now trying to recap the issue https://github.com/kubevirt/kubevirt/issues/8615, as I was also trying to reproduce it (but without any luck, unfortunately), and take into account the recent findings (e.g....
@naiming-zededa, **instead** of doing `setcap cap_dac_override=ep /usr/libexec/qemu-kvm`, could you try just setting the proper access bits to the device files in the `cmd/virt-launcher/node-labeller/node-labeller.sh`? ```diff diff --git a/cmd/virt-launcher/node-labeller/node-labeller.sh b/cmd/virt-launcher/node-labeller/node-labeller.sh index 51b02546d..4f40983a3...
/reopen /remove-lifecycle rotten