Vasiliy Ulyanov
Vasiliy Ulyanov
Seems that previously there were some attempts. You may take a look at https://github.com/kubevirt/kubevirt/issues/2763. The issue lists some prerequisites. Though I am not sure this is currently supported in KubeVirt.
> /cc @xpivarc > > related to the migration abort flakes. Just to note: this PR is only about fixing the **unit** tests.
> I think it is preferable to invoke `mockDomain.EXPECT().Free()` in a [defer cleanup](https://onsi.github.io/ginkgo/#cleaning-up-our-cleanup-code-defercleanup) - a ginkgov2 construct, since it would require less test changes. Hi @maiqueb . Thank you for...
> IIUC - I might be missing something - we just have to ensure the `. Free()` function is invoked on the `mockDomain` struct. As such, I think it can...
/retest-required
> I left some minor notes but overall I'm still digesting this PR :) Thanks a lot Thanks for the review, @iholder-redhat . I rebased the changes and addressed the...
> > To which other approaches do you refer? smiley Is it revolving around node-labeller implementation? Maybe it's good to open your concerns to discussions :) Yeah, sorry if my...
> Overall looks good to me! > Thanks for the review! > I just have a couple of questions/remarks: > > 1. Have you thought to unpause the VM with...