Mike Frysinger
Mike Frysinger
this is likely something we want to fix, but we don't use GH to track changes. please see our docs: https://github.com/GerritCodeReview/git-repo/blob/main/SUBMITTING_PATCHES.md
the fact the docs live in this repo is irrelevant. it specifically has a [Sending your patches](https://github.com/GerritCodeReview/git-repo/blob/main/SUBMITTING_PATCHES.md#sending-your-patches) section that explains where to send things. you can clone the repo from...
we try to avoid ad-hoc overflow checks. this is kind of what the overflow2() helper is for, although that operates on `int` rather than `int64_t`. can you define a new...
this doesn't feel like an integer overflow, and the checks don't seem to make sense. the coordinates should not be negative (we might be missing a check for that), which...
can you attach a full run with these settings against the existing docs ? or are they all clean other than the fixes you included ?
the image in question comes from the CC project themselves. we could probably embed a larger version, but I think the current size looks fine. thanks for the suggestion.
the intent is to not have trailing whitespace. many editors & formatters will flag & delete it automatically.
It happens on non-async too. I just grabbed the first set of failures and reduced it down.
it's not a Google-specific term. Wikipedia explains it: https://en.wikipedia.org/wiki/Version_control#Change_list
makes things smoother when playing with a child who needs help every now and then