Patrick Van Stee

Results 29 comments of Patrick Van Stee

Oh yeah we need this! Could you add some test coverage? Actually, it might be nice to pull this out into its own object. What do you think?

I've been thinking about this a little more. Since we don't want to block for the response, it might be nice to register a callback to run every time there's...

Oh yeah good call. That's got me thinking now. What if you want to check equality of 2 invalid notifications? Comparing instance variables might be better than the result of...

Yeah I agree that serializing the data is not important for equality.

I think we should probably just not accept the PKCS12 format when using jruby. I'd rather just have jruby users do the conversion on their own (especially since Apple recommends...

Since adding connection pooling will probably increase the complexity of the gem, it might be nice to have some numbers on how it improves performance so we can better make...

@d11wtq Ruby has a built-in thread-safe queue implementation http://www.ruby-doc.org/stdlib-1.9.3/libdoc/thread/rdoc/Queue.html

Hrm. Actually thinking about that again now, using a `Queue` might make it tough to remove a connection from the `used` queue.

So if the main purpose of adding connection pooling support is actually just to make things thread-safe, @d11wtq would you be happy with just wrapping up `#push` in a `synchronize`...