Vanja Pejovic

Results 15 comments of Vanja Pejovic

> I don't have a good way of replicating the data to my local clickhouse setup You can run clickhouse locally and connect the app to it: http://go/how/operations#run-a-local-clickhouse-server. Not sure...

This LGTM, but I'm not a great choice for reviewing the redis code.

What about keeping the last N bytes of stdout/stderr instead of failing the action? If we drop some data, we could prepend something like "Output had a total of N...

I should mention that grpc-go users can override the default pool for clients and servers with options, but the same isn't possible for the [`DefaultBufferPool()` uses in the proto encoder](https://github.com/vanja-p/grpc-go/blob/9fd5d8aa03e6f7380f9bec3a8c836b3bf31954e7/encoding/proto/proto.go#L73-L91)....

> I think that because lookaside cache is in memory only and zeroed on app restart we should move these checks to `addLookasideEntry` instead? Good point. Done.

> How does this work if the local and remote environments have different glibc versions and we are linking a cgo-enabled binary? Will the binary be linked against whichever one...

If the local action wins the race, do you know if the result is cached remotely?

Unless the remote action isn't cancelled. Also, the missing inputs could still be uploaded without caching the action result. I'm just trying to make sure that by enabling this for...

This sometimes causes builds to fail, so I've stopped using it. Didn't try to fix it yet, so putting this in draft.

```ERROR: /home/vanja/src/buildbuddy/enterprise/server/util/distributed_client/BUILD:30:8: GoLink enterprise/server/util/distributed_client/distributed_client_test_/distributed_client_test failed: (Exit 1): builder failed: error executing GoLink command (from target //enterprise/server/util/distributed_client:distributed_client_test) (cd /home/vanja/.cache/bazel/_bazel_vanja/74da49126678a995920acffee3a5843e/sandbox/processwrapper-sandbox/6665/execroot/buildbuddy && \ exec env - \ CGO_ENABLED=1 \ GOARCH=amd64 \ GODEBUG='winsymlink=0' \...