Don van den Bergh

Results 20 comments of Don van den Bergh
trafficstars

Sorry about that, the second case is indeed correct. I added it because initially, I was unsure whether `log_inv_logit_diff` did `x - y` or `y - x`. Thanks for fixing...

so this probably works, but because we no longer do `library(jaspBase)` by default I'm now seeing ![image](https://user-images.githubusercontent.com/21319932/180998957-efe61863-8cbe-449c-a6ae-a3cb8b124608.png) for all our custom functions...

> So... I can move https://github.com/jasp-stats/jasp-desktop/commit/e9e8011c7d663cfefc75eb3e23b05b390064b072 to stable I don't like it, but maybe it's best to do that for now. The downside is that every module needs to be...

Looks good to me! The only nitpick I have is that the log2 and log10 should use subscript base rather than superscript base: ![image](https://user-images.githubusercontent.com/21319932/188127014-58450b59-ed3f-4baa-897b-3b8803caac50.png) but Wikipedia (and others) do this:...

> Since the sufficient statistics are internal unexported implementation details of the fit! pipeline Perhaps I'm missing something, but `suffstats` is exported? https://github.com/JuliaStats/Distributions.jl/blob/0c9367ca7a7549d46c12d05b0ee5ec8e5000bc13/src/Distributions.jl#L258 > I think the correct approach is...

What I mean is, am I doing something wrong (which is certainly possible), or is it right now not possible to use the static version while setting the configure vars?...

@fsmosca I'd be happy to skip that, but unfortunately, that does not work. For example: ```julia using Chess, Chess.PGN filename = "crazyhouse_test.pgn" println(read(filename, String)) result = SimpleGame[] for g in...

> SMC is a bit special, these options don't make sense. In that case, shouldn't a DomainError be thrown for the sake of user-friendliness whenever these options are set?

@JorisGoosen can this be closed? :stuck_out_tongue:

@JorisGoosen sorry for the delay, feel free to push directly to this branch!