Vandan

Results 36 comments of Vandan

What if we explicitly display both UTF-8 and raw hex string versions of the message they are being asked to sign within the wallet? @bschorchit should we simply encourage use...

@bschorchit - I believe the advantage would be that displaying both avoids the need for implicit data type detection. @BelfordZ can add more detail there. People may also want to...

Could not reproduce on Chrome (MacOS). Needs reproduction with Chrome on Linux.

We will add a small note to the https://docs.metamask.io/wallet/reference/eth_signtypeddata_v4/ documentation to clarify how our implementation works.

Confirmed that there is an issue in the logic here: https://github.com/MetaMask/metamask-mobile/blob/cd353bb94584b5995fc93e7ac0394cd1916f7292/app/core/RPCMethods/wallet_addEthereumChain.js#L120-L122 Should behave similar to the logic in the Extension.

@gauthierpetetin This is an on-chain execution revert. We wouldn't expect these errors to be logged. Is this causing an error in the mobile application?

re-assigning back to mobile platform for now

Now that EIP-6963 support is live in the MetaMask Extension, getting the SDK in to the MetaMask Connector would help accelerate further EIP-6963 adoption and bring some nice UX improvements...