valeriaRaffuzzi

Results 16 comments of valeriaRaffuzzi

This looks like a good idea to me. So you are envisioning two PPs, one for eigenvalue and one for fixed source like in MC? Or maybe a noisePP will...

> Looks good and thanks for the changes. But because it is geometry it makes me super paranoid 😨 Did you run a lot of surface tracking calculations with the...

> > Looks good and thanks for the changes. But because it is geometry it makes me super paranoid 😨 Did you run a lot of surface tracking calculations with...

> Thanks for this. My most major comment is just on keeping temperature as a separate variable which I think we would like to distinguish without demanding TMS (e.g., for...

> * QUESTION: should the sampled energy be used for scatterInLab and ScatterFromFixed too???????? @Mikolaj-A-Kowalski @ChasingNeutrons I can see you didn't read the PR description!!! Does anyone have an intuition...

Apologies for adding yet more stuff! I implemented all of the reviews: - A lot of them were typos, aesthetic stuff and some docs. - I removed `collisionE` from the...

1. I don't have a strong preference, but I don't think it's necessary to rebase. 2. How long are we talking about? The compilation is already quite slow, so it...

Other than the conflicts coming from the recent PRs that we just merged, I don't think that this PR will break anything. In the future probably having a script that...

[slab1dCE.txt](https://github.com/CambridgeNuclear/SCONE/files/9480458/slab1dCE.txt) I attached the file that causes the drama. Its's a series of thin slabs reflective anywhere except for the +x end, with a source in void at the -x...

OK, I checked and that is exactly the problem. The difference between the two distances is bigger than the tolerance (some 6e-8 > 2e-8).