Valentin Gosu

While I would prefer a consistent behaviour such as escaping all spaces in a path, I suspect it might be easier to just escape or strip the trailing spaces. I...

Firefox developer here: I closed the Firefox bug since it appears this is a bug in the webextension. If there's anything we can do to help with a fix please...

@zcei I think that's the correct approach. I'm not sure if we really need to change the error handling though - but we can. > Or we could go with...

> For the moment I have introduced BareItem::Validated* variants adjacent to their unvalidated enum member counterparts. Do you see us keeping both Validated and unvalidated enum types, or do you...

> let's rename the current enum members to something like Raw* / Unvalidated* / Unsafe* members. Would they still be in the same enum as the validated types? Either way,...

We can consider that for a follow-up change. For now let's keep using Decimal. On Wed, 15 Feb 2023 at 10:51, Stephan Schneider ***@***.***> wrote: > ***@***.**** commented on this...

I think one example why you wouldn't want to enforce a DNS limit on URLs is something like Tor onion URLs. As far as I can tell right now it's...

I've managed to reliably reproduce this using this [patch](https://treeherder.mozilla.org/jobs?repo=try&revision=6c41522e4d9d16d81c215ca0de315406cf5f01cb) Build with asan: ``` MOZBUILD=/home/icecold/.mozbuild mk_add_options AUTOCLOBBER=1 ac_add_options --enable-address-sanitizer ac_add_options --enable-debug ac_add_options --enable-debug-symbols ac_add_options --disable-jemalloc ac_add_options --disable-crashreporter ac_add_options --disable-elf-hack mk_add_options MOZ_OBJDIR=/home/icecold/mozilla-unified/obj-asan-opt...

I'm not sure if it's relevant, but I also filed [bug 1543624](https://bugzilla.mozilla.org/show_bug.cgi?id=1543624) a while ago.

If we're moving towards a 1.0 release, then we most definitely have one 👍