sfv icon indicating copy to clipboard operation
sfv copied to clipboard

Should sfv have a minimum-supported Rust version (MSRV) policy?

Open apasel422 opened this issue 9 months ago • 2 comments

Currently it does not.

apasel422 avatar Feb 27 '25 15:02 apasel422

If we're moving towards a 1.0 release, then we most definitely have one 👍

valenting avatar Feb 27 '25 16:02 valenting

I'm a bit new to this concept, so if you want to propose a policy here, that'd be great.

apasel422 avatar Mar 19 '25 18:03 apasel422

The first rust version that builds this crate successfully is 1.77

For 1.76 I get:

$ rustup run 1.76 cargo check
...
Checking sfv v0.10.4 (/home/icecold/workspace/sfv)
error[E0658]: use of unstable library feature 'round_ties_even'
   --> src/decimal.rs:167:46
    |
167 |         match Integer::try_from((v * 1000.0).round_ties_even() as i64) {
    |                                              ^^^^^^^^^^^^^^^
    |
    = note: see issue #96710 <https://github.com/rust-lang/rust/issues/96710> for more information

valenting avatar Mar 25 '25 11:03 valenting