Val Doroshchuk comments

Results 86 comments of


                                            Val Doroshchuk

Integration in digiKam (Qt5): some helps required.

looks made mistake with LIBAVUTIL_VERSION_MAJOR, ``` #if LIBAVUTIL_VERSION_MAJOR < 58 format.setChannelCount(d->avctx->channels); #else format.setChannelCount(d->avctx->ch_layout.nb_channels); #endif ``` Do you know what is LIBAVUTIL_VERSION_MAJOR for you?

Integration in digiKam (Qt5): some helps required.

https://github.com/valbok/QtAVPlayer/pull/431 > > 2/3s delay before to take effect > > Right, looks bug, volume is changed only when new frame is arrived which is not nice. Thanks, will fix

Integration in digiKam (Qt5): some helps required.

Did you have a chance to figure out why player->position() returns 0 for you? but it still sends audio frames? Could you add `qDebug()

QAVAudioFrame::data() reinitializes the resampler over and over again

> Finally, there is a strange line in the code where outCount is calculated. > This line should simply be: int outCount = frame->nb_samples; > av_samples_get_buffer_size takes care of the...

QAVAudioFrame::data() reinitializes the resampler over and over again

Thanks @pasveer, just merged the fix to reuse SwrContext, could you please check if it works for you? Thanks again PS Sorry for long delay.

Falha ao compilar o qtavplayer no QT 6.7.2

thanks, will provide a fix a bit later.