Val Doroshchuk
Val Doroshchuk
https://github.com/valbok/QtAVPlayer/pull/465
Thanks for pointing this. QAVAudioOutput should definitely be fixed, yes. It is been a while since it was implemented. But first version was very naive and 1. found out that...
Also increasing the buffer size usually helps with crackling. When decoding is too slow and audio device is waiting for more data.
btw https://github.com/valbok/QtAVPlayer/blob/master/src/QtAVPlayer/qavaudiooutput.cpp#L196 technically it is not busy loop, it is running only if there is a frame in a queue and waiting until new frame is arrived.
could you please share your test?
btw, maybe the magic happens when you return zeros and silence instead of waiting for more data, which avoids any noize.
sorry for delay, I tried your example, and found some issues like need to have a way to stop QThread and at EOF, there is crackling. For now it is...
> > Also QThread itself already contains QEventLoop, looks another one is not needed. > > Thanks for pointing me to this, I did not realize that. Now I can...
sorry for the delay, finally got working https://github.com/valbok/QtAVPlayer/pull/464 locally, tested on mac, win and lin. 1. Took your idea that QThread should be used 2. Since QThread has its own...
> From my understanding, with this code all in QAvAudioOutput should be moved to the QThread, also whatever is created > later in the QAvAudioOutput class on the heap. 1....