Daniel Valadas

Results 205 comments of Daniel Valadas

I would prefer release tagging instead of automatically having a release on each merge. I do not like the idea of a release for each merged PR, sometimes, you need...

I am unclear on the meaning of release vs a normal/full release. CI will make a build on each pull request, it will also generate a build on each merge...

@EPTamminga ok, for me that is a release, the other builds are just "nightly builds" or builds. Now if I understood correctly, the automatic release notes would update the release...

@vmasanas @SCullman if I understand correctly, this would be an additional type installed separately from the module itself correct? I don't know that we want to add and maintain in...

Yes, my concern is 2-fold. 1 is the security (which we can handle with Dnn APIs for sure), the other is storage (as it could be used to fill storage...

Well, it's true for many other form modules but for this one it was never the case. By design it only allowed logged in users to upload.

Yes, in my opinion I would approve a solution that comes in that does not touch the filesystem. If the file does get saved to the filesystem I would be...

Good idea, but I see two possible problems. 1. The site may not be using https, in which case that statement would be false. So when implementing this, it should...

@SCullman published this module to manage site groups https://github.com/SCullman/Connect.Sitegroups there is one published release and it looks like he is working on a 9.3+ compatible release. I would help if...

> I don't have time to fix that and I spend already too many hours on that I can offer help if you need to fix stuff and then submit...