Ivan Dlugos
Ivan Dlugos
@copilot the CI is failing, have a look. Additionally, the CI output still has 10000 lines of output. Think how this could be improved. Consider only printing output in case...
@copilot the output is still very long, some suggestions: - move pip install to a separate step in ci.yml - don't print executed cmake commands unless they fail - executing...
@copilot The test test_enhanced_error_format manually recreates error formatting logic instead of testing the actual format_error_output function. This creates maintenance burden and doesn't actually test the real implementation. Consider importing and...
@copilot The run_with_capture_on_failure function has a potential resource leak. The subprocess.Popen object is created but if an exception occurs during the output reading loop (other than CalledProcessError), the process may...
@copilot The final process.wait() after kill() could potentially hang. Consider adding a timeout or using wait(timeout=1). ``` (tests/__init__.py:145-152) try: process.wait(timeout=5) except subprocess.TimeoutExpired: process.kill() process.wait() ``` After that's fixed, cleanup the...
@copilot CI is broken
> > @copilot CI is broken > > Fixed the CI failure caused by missing psutil dependency in the resource cleanup test. Made the test conditional to skip gracefully when...
@copilot update PR description, concentrating on "why" not "what" changed
@copilot fix CI failures